Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes Blueshift's forge door randomly bolting. #1874

Closed
wants to merge 1 commit into from

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#797

About The Pull Request

Turns out, it's not just randomly bolting. It was copied from the commissary so whenever someone bolted the commissary, it bolted the forge, too.

How This Contributes To The Nova Sector Roleplay Experience

Doors "randomly" bolting you in isn't fun,

Changelog

🆑 sqnztb
fix: blueshift's forge no longer randomly bolts shut.
/:cl:

@Iajret Iajret closed this Feb 9, 2024
@Iajret Iajret deleted the upstream-mirror-797 branch February 10, 2024 11:15
Iajret pushed a commit that referenced this pull request Apr 9, 2024
…items (knight armor, tiles) (#1874)

* Material datum color update, plus touching up some material items (knight armor, tiles) (#82500)

## About The Pull Request

Tries to bring the material datum colors in closer approximation to the
stacks they're attached too. I literally used the colors on the stacks.
some might need to be lighter or darker, but for the most part they'll
look...closer to their actual material hues.

![material datum stuff
2](https://github.com/tgstation/tgstation/assets/40847847/a3a5968f-cab3-43dd-8699-3dae879b21fb)

I've also tweaked the sprites of both the tile object and the actual
material tile turf to give it the right shading.


![image](https://github.com/tgstation/tgstation/assets/40847847/56489479-8774-492b-b8cc-aeabc6c0a67f)

In addition to the tiles, I've also updated the knight armor and helmet
to look closer to the much higher quality plate armor already in the
game.

## Why It's Good For The Game

It bothered me that the material datum coloring was inconsistent with
the actual colors used for the material stacks. When they were updated,
and even before they were updated, material datum stuff just never
looked _right_. I wanted to change that so that it looks just right.

I did not like the old material knight armor whatsoever. It was a
dithered mess, and seemed to already use parts of the standard plate
armor but with all the actual shading removed or replaced with the wrong
colors. This fixes that so that the armor is actually readable for what
it is.

## Changelog
:cl:
image: Updates the colors of various material datum to bring them closer
in-line with their actual material stacks
image: Improves the sprites for the material knight armor and helmet.
/:cl:

* Material datum color update, plus touching up some material items (knight armor, tiles)

---------

Co-authored-by: necromanceranne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants